Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples): Implement GNS (Gno Name Service) #2

Closed
wants to merge 15 commits into from
Closed

feat(examples): Implement GNS (Gno Name Service) #2

wants to merge 15 commits into from

Conversation

linhpn99
Copy link
Collaborator

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

thinhnx-var
thinhnx-var reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@thinhnx-var thinhnx-var left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ownable not used

examples/gno.land/p/demo/gns/domain_registry.gno Outdated Show resolved Hide resolved
@linhpn99 @thinhnx-var
Update examples/gno.land/p/demo/gns/domain_registry.gno
7b6d072 
Co-authored-by: ThinhNX <168700277+thinhnx-var@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@linhpn99 linhpn99 closed this Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinhnx-var thinhnx-var thinhnx-var left review comments

Assignees

@linhpn99 linhpn99

Labels
🧾 package/realm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linhpn99 @thinhnx-var